Hi, > Hi Andrew, > > There is a bug repeated twice in your code. > In both dns_reset_resolution() and trigger_resolution(), you use > "resolution->resolver_family_priority" before it is positioned. This > may lead to using the last resolution->resolver_family_priority, which > may be different than the server one. > Please move the line "resolution->resolver_family_priority = > s->resolver_family_priority;" before using the value stored in it.
Andrew if you respin this patch, could you include in the commit message the information from Robin here [1], which boils down to the fact that an ANY query doesn't necessarily trigger an upstream dns lookup, but may just serve its cache contents [2]. Also, we will have to address the issue that a server may just use a single address-family, therefor we have to fallback between A and AAAA, because a NX on a AAAA query doesn't mean there are no A records. Thanks, Lukas [1] http://marc.info/?l=haproxy&m=144492760419607&w=2 [2] https://github.com/jedisct1/unbound/commit/792c5187fccc33b0866eed1b80e4f5a3d5ce3235
