Sorry for being thickheaded, Willy, but what's your decision here — do you want me to make it per-Backend instead of per-Server, or do you want to merge it as-is?
I'm glad to defer completely to your judgement on this. On Thu, Oct 22, 2015 at 1:12 PM, Willy Tarreau <[email protected]> wrote: > On Thu, Oct 22, 2015 at 01:04:28PM -0700, James Brown wrote: > > It would be... more convenient for my use case to be able to encode the > > string in the config (we may have several backends for a different > service > > to correspond to phased deployment rollouts, and I'd prefer to encode the > > logic for mapping backend name to service name in my existing haproxy > > config templating script rather than adding it to the agent script). If > you > > think it's significantly better, I could make it a static string, though, > > and bite the bullet for complexity in the agent. > > OK. Stick to your configurable string then. If we later want something > automatic we can use a special keyword. You may even reserve the string > "auto" or something like this as an argument to indicate that the string > will be automatically filled. > > > We could also do something where we defined it per-backend (like the way > > `option httpchk` works now; I could easily change this to a backend > > parameter set with `option agent-send` or whatever). > > I was thinking about something like this as well. It's true that if you > want something automatic then you don't want to configure it on each and > every server! > > OK thus I think we can merge your patch then. > > Regards, > Willy > > -- James Brown Engineer
