On Tue, Dec 08, 2015 at 11:59:29AM +0800, Ruoshan Huang wrote: > > > On Dec 8, 2015, at 3:26 AM, Willy Tarreau <[email protected]> wrote: > > > > Would you be willing to propose your first patch to address > > this ? reqadd, reqdel, reqdeny, reqallow, rspadd, rspdel, rspdeny, rspallow > > are directly concerned. > > > Yes, I???d love to update the doc. > > There is one problem here: > the `reqdel reqidel` works with regular exp, but `http-response del-header` > only works with plain text. so those old directives are not as > ???deprecated??? as they are :)
That's true but in practice we almost never need them. The only case is when you want to remove headers which you don't precisely know the name, for example all private headers starting with a known prefix. I don't know if another word is better than "deprecated". Maybe "not recommended for new designs" ? > Also, the `rspadd rspdel` runs after `http-response` so things like below > would not works as expected: > ``` > rspadd XX:\ default > http-response set-header XX other if COND > ``` > the `XX: default` hdr will always in response, can I have this behaviour > stated in the doc too? Sure, I'm sorry if I made it sound like it could easily be replaced that easily, that's not what I meant. My point really was to discourage users from using these keywords in newer configs. I know there's no 1-to-1 mapping. Feel free to add examples for each keyword if you want! The doc first appears quite complete, until you need it and discover that there are not that many examples. So it's a collaborative effort to make it as clear as possible. Any input is welcome. Thanks! Willy
