Hi,
Am 11.04.2016 um 23:20 schrieb Willy Tarreau:
Excellent, thanks very much for confirming! I feel like I'm not completely
obsolete yet if I can still spot such an issue by reading the code then
write the reproducer :-)
Nah, you're the buffer and polling man, you will never be obsolete :)
Jokes aside, what troubles me here is that if it wouldn't be for 1.5, we
would
probably not have found this bug at all.
I'm not familiar with the specifics, but it seems the polling loop
protection in 1.6+
can hide relevant bugs. Is there anything that can be done, to benefit
from the
loop protection but in a way we can spot those issue nonetheless?
I think nginx does emit "zero size buf" warnings in cases like this, so
bugs can be reported and fixed (but I'm not entirely sure this applies
to the polling loop protection): For example:
http://hg.nginx.org/nginx/rev/ad3f342f14ba
http://hg.nginx.org/nginx/rev/a24f88eff684
http://hg.nginx.org/nginx/rev/6ab301ddf469
http://hg.nginx.org/nginx/rev/4aa64f695031 Thoughts (I don't have a good
low level understanding of this issues, so please bear with me)? lukas
