Hi, On 14 December 2016 at 14:48, <[email protected]> wrote: > Hi, thanks for the patch. > > Maybe it is more efficient to simply add a "#define _KERNEL", or the > following code: > > #if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) > #define _KERNEL > #endif >
It is easy (and temptating) but not a good practice ... in my opinion :-) > I'm not sure that src_hlua.c was the good file for adding these > kinds of defines or includes. Even if these defines are used only in > this file, I suppose that it should be used in other file (in the > future). > I was not sure myself, I hesitated to put it in one of the headers ... let me know what you all think. Cheers. > unfortunately, pattern mathing use only the length in bits of the mask. > I can't compare. > > Maybe Willy have an opinion about this ? > > Thierry > > > On Wed, 14 Dec 2016 13:42:26 +0000 > David CARLIER <[email protected]> wrote: > >> On Linux it s also an "alias" if I m not mistaken, someone might >> confirm it or not though. Kind regards. >> >> On 14 December 2016 at 13:32, Dmitry Sivachenko <[email protected]> wrote: >> > >> >> On 14 Dec 2016, at 16:24, David CARLIER <[email protected]> wrote: >> >> >> >> Hi, >> >> >> >> I ve made a small patch for 1.8 branch though. Does it suit ? (ie I >> >> made all the fields available, not sure if would be useful one day). >> >> >> > >> > Well, I was not sure what this s6_addr32 is used for and if it is possible >> > to avoid it's usage (since it is linux-specific). >> > If not, then this is probably the correct solution. >> > >>
