Hi Willy,

As requested, attached :-)

-=david=-

On 2 January 2017 at 13:34, Willy Tarreau <[email protected]> wrote:

> Hi David,
>
> On Mon, Jan 02, 2017 at 11:50:50AM +0000, David Harrigan wrote:
> > That's great! I'm glad it appears to be safe. Is there anything else you
> > would like me to do, or is it in reasonably good shape to be included as
> a
> > patch into 1.8 (possibly backported as well?)
>
> Ah I didn't notice that you already posted it. I tried to apply it but
> it was completely mangled by your mailer apparently. Could you please
> just repost it as an attachment ? Regarding the backportability, I think
> it's reasonable to consider it for 1.7.
>
> Thanks,
> Willy
>



-- 
I prefer encrypted and signed messages.
Fingerprint: 110A F423 3647 54E2 880F ADAD 1C52 85BF B20A 22F9

No trees were harmed in the sending of this message, however, a number of
electrons were inconvenienced.
From 218a6c42d47ccf2d8970e1d332c91429a2c34bbb Mon Sep 17 00:00:00 2001
From: David Harrigan <[email protected]>
Date: Fri, 30 Dec 2016 12:12:49 +0000
Subject: [PATCH] MINOR: stats: Support "select all" for backend actions

Allow the user to quickly select all servers within a group before invoking an
action.
---
 src/stats.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/stats.c b/src/stats.c
index 497aa477..d5fcec82 100644
--- a/src/stats.c
+++ b/src/stats.c
@@ -636,7 +636,8 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats,
 
 		if (flags & ST_SHOWADMIN)
 			chunk_appendf(out,
-			              "<td><input type=\"checkbox\" name=\"s\" value=\"%s\"></td>",
+			              "<td><input class='%s-checkbox' type=\"checkbox\" name=\"s\" value=\"%s\"></td>",
+			              field_str(stats, ST_F_PXNAME),
 			              field_str(stats, ST_F_SVNAME));
 
 		chunk_appendf(out,
@@ -1642,7 +1643,12 @@ static void stats_dump_html_px_hdr(struct stream_interface *si, struct proxy *px
 
 	if ((px->cap & PR_CAP_BE) && px->srv && (appctx->ctx.stats.flags & STAT_ADMIN)) {
 		/* Column heading for Enable or Disable server */
-		chunk_appendf(&trash, "<th rowspan=2 width=1></th>");
+        chunk_appendf(&trash,
+                "<th rowspan=2 width=1><input type=\"checkbox\" \
+                onclick=\"for(c in document.getElementsByClassName('%s-checkbox')) \
+                document.getElementsByClassName('%s-checkbox').item(c).checked = this.checked\"></th>",
+                px->id,
+                px->id);
 	}
 
 	chunk_appendf(&trash,
-- 
2.11.0

Reply via email to