On Wed, Jan 11, 2017 at 10:47:18PM +0000, Lukas Tribus wrote: > The output of whether prefer-server-ciphers is supported by OpenSSL > actually always show yes in 1.8, because SSL_OP_CIPHER_SERVER_PREFERENCE > is redefined before the actual check in src/ssl_sock.c, since it was > moved from here from src/haproxy.c. > > Since this is not really relevant anymore as we don't support OpenSSL > < 0.9.7 anyway, this change just removes this output. (...)
Applied, thank you Lukas! > I did not find any other outputs, unless you meant actual #defines for > older openssl compatiblity as well? I would leave them as-is. It may be > useful for OpenSSL forks or forward compatibility if those macros get > removed from upstream OpenSSL. I only meant if other macros used in #ifdef for compatibility reasons induce some dead code that never gets built anymore, then we can remove them. But don't waste your time on this, it's neither fun nor useful. At best it will make the code cleaner :-) Cheers, Willy
