Hi Christopher, On Fri, Dec 01, 2017 at 11:59:14AM -0800, Christopher Lane wrote: > gist with backtrace, -vv output, and config file. Also strace. > > https://gist.github.com/jayalane/c6dbe7918aa9635b62c874d20f57dfec > > It does all the listens and then right after the first epoll is done it has > this segv. all the local variables are "optimized out" > > (We really want the hard-stop-after -- we get a leak of children with our > super frequent soft-reloads). > > It's possible something is messed up in my compiling/linking environment, > but I don't see anything, and I thought maybe a .0 release had a chance of > issues on very old RHEL versions. We currently run 1.5 and have to > manually clean up the left over children (but are hoping to scale up to > nbproc 4 and use CPU pinning). > > I'm debugging also, but hoped someone would have something off the top of > their head (apologies for not having read the list for a while before > posting). >
Thanks a lot for the very detailled report ! I think I know what's going on. In your config file, you have : server stage.qa.example.com:11302 stage.qa.example.com check inter 2m fastinter 2s fall 2 It should probably be : server stage.qa.example.com stage.qa.example.com:11302 check inter 2m fastinter 2s fall 2 However this is of course no reason to segfault. Can you please try the attached patch, and let me know if it fixes your issue ? Thanks a lot ! Olivier
>From 5236a1a4ac19cc27c6f06d328b2df0c4cdfe220c Mon Sep 17 00:00:00 2001 From: Olivier Houchard <[email protected]> Date: Fri, 1 Dec 2017 22:04:05 +0100 Subject: [PATCH] MINOR: checks: Be sure we have a mux if we created a cs. In connect_conn_chk(), there were one case we could return with a new conn_stream created, but no mux attached. With no mux, cs_destroy() would segfault. Fix that by setting the mux before we can fail. This should be backported to 1.8. --- src/checks.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/checks.c b/src/checks.c index 63747201e..eaf84a225 100644 --- a/src/checks.c +++ b/src/checks.c @@ -1564,25 +1564,23 @@ static int connect_conn_chk(struct task *t) conn->addr.to = s->addr; } + proto = protocol_by_family(conn->addr.to.ss_family); + + conn_prepare(conn, proto, check->xprt); + conn_install_mux(conn, &mux_pt_ops, cs); + cs_attach(cs, check, &check_conn_cb); + conn->target = &s->obj_type; + if ((conn->addr.to.ss_family == AF_INET) || (conn->addr.to.ss_family == AF_INET6)) { int i = 0; i = srv_check_healthcheck_port(check); - if (i == 0) { - cs->data = check; + if (i == 0) return SF_ERR_CHK_PORT; - } set_host_port(&conn->addr.to, i); } - proto = protocol_by_family(conn->addr.to.ss_family); - - conn_prepare(conn, proto, check->xprt); - conn_install_mux(conn, &mux_pt_ops, cs); - cs_attach(cs, check, &check_conn_cb); - conn->target = &s->obj_type; - /* no client address */ clear_addr(&conn->addr.from); -- 2.14.3
