Hi All, This bug should be fixed using this patch (patch on dev, abd should be backported in 1.8).
R, Emeric On 12/21/2017 10:42 AM, Greg Nolle wrote: > Thanks guys! I should be able to test the new version this weekend if you are > able to issue it before then. > > Best regards, > Greg > > On Thu, Dec 21, 2017 at 12:15 AM, Willy Tarreau <[email protected] > <mailto:[email protected]>> wrote: > > On Thu, Dec 21, 2017 at 12:04:11AM +0100, Cyril Bonté wrote: > > Hi Greg, > > > > Le 20/12/2017 à 22:42, Greg Nolle a écrit : > > > Hi Andrew, > > > > > > Thanks for the info but I'm afraid I'm not seeing anything here that > > > would affect the issue I'm seeing, and by the way the docs don't > > > indicate that the cookie names have to match the server names. > > > > First, don't worry about the configuration, there is nothing wrong in > it ;-) > > > > > That being said, I tried using your settings and am still seeing the > > > issue (see below for new full config). And like I say, this is only an > > > issue with v1.8.1, it works as expected in v1.7.9. > > > > I won't be able to look further tonight, but at least I could identify > when > > the regression occured : it's caused by the work done to prepare > > multi-threading, more specifically by this commit : > > http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=64cc49cf7 > <http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=64cc49cf7> > > > > I add Emeric to the thread, maybe he'll be able to provide a fix faster > than > > me (I'll won't be very available for the next days). > > Thus I'll ping Emeric tomorrow as well so that we can issue 1.8.2 soon in > case someone wants to play with it on friday afternoon jus before xmas :-) > > Willy > >
>From db483435c294541cbab27babacb9daefc043fd32 Mon Sep 17 00:00:00 2001 From: Emeric Brun <[email protected]> Date: Thu, 21 Dec 2017 14:42:26 +0100 Subject: [PATCH] BUG/MEDIUM: checks: a server passed in maint state was not forced down. Setting a server in maint mode, the required next_state was not set before calling the 'lb_down' function and so the system state was never commited. This patch should be backported in 1.8 --- src/server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index 23e4cc9..a37e919 100644 --- a/src/server.c +++ b/src/server.c @@ -4630,10 +4630,11 @@ void srv_update_status(struct server *s) else { /* server was still running */ check->health = 0; /* failure */ s->last_change = now.tv_sec; + + s->next_state = SRV_ST_STOPPED; if (s->proxy->lbprm.set_server_status_down) s->proxy->lbprm.set_server_status_down(s); - s->next_state = SRV_ST_STOPPED; if (s->onmarkeddown & HANA_ONMARKEDDOWN_SHUTDOWNSESSIONS) srv_shutdown_streams(s, SF_ERR_DOWN); -- 2.7.4
