Hi Stephen, On Wed, Jan 03, 2018 at 08:33:14PM +0100, PR Bot wrote: > Dear list! > > Author: Stephen <[email protected]> > Number of patches: 1 > > This is an automated relay of the Github pull request: > avoid overriding external prefix > > Patch title(s): > avoid overriding external prefix > > Link: > https://github.com/haproxy/haproxy/pull/82
>From d14f3c9d806bfe6e6b7e1fb81ab9973b04d2736a Mon Sep 17 00:00:00 2001 From: Stephen <[email protected]> Date: Wed, 3 Jan 2018 09:28:35 -0800 Subject: [PATCH] avoid overriding external prefix --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 8927919b..755503d4 100644 --- a/Makefile +++ b/Makefile @@ -91,7 +91,7 @@ #### Installation options. DESTDIR = -PREFIX = /usr/local +PREFIX ?= /usr/local SBINDIR = $(PREFIX)/sbin MANDIR = $(PREFIX)/share/man DOCDIR = $(PREFIX)/doc/haproxy I'm wondering why it is that over the last few weeks we received a few such wrong patches while we never had them in 15 years. Maybe we need to add a few lines to the makefile explaining how to use a makefile and why it's *always* wrong to use "?=" (it inherits whatever randomly lies in your environment). Please have a look at the longer explanation I sent here a few days ago : https://www.mail-archive.com/[email protected]/msg28390.html Thanks, Willy
