Hi, On Thu, Jan 04, 2018 at 11:17:13AM +0500, ???? ??????? wrote: > 2018-01-04 2:13 GMT+05:00 Willy Tarreau <[email protected]>: > > I'm wondering why it is that over the last few weeks we received a few > > such wrong patches while we never had them in 15 years. Maybe we need > > to add a few lines to the makefile explaining how to use a makefile and > > why it's *always* wrong to use "?=" (it inherits whatever randomly lies > > in your environment). > > > > if it is wrong, why is it used almost everywhere :) > > # find . -name Makefile -exec grep '?=' {} ';' -print > CC ?= gcc > ./Makefile > CC ?= gcc
This one is wrong, it's your patched makefile I guess. > ./contrib/tcploop/Makefile > CC ?= gcc > ./contrib/iprange/Makefile > CC ?= gcc > CXX ?= g++ > ./contrib/mod_defender/Makefile > CC ?= gcc > ./contrib/spoa_example/Makefile > CC ?= gcc > ./contrib/debug/Makefile > CC ?= gcc > ./contrib/halog/Makefile > CC ?= gcc > ./contrib/modsecurity/Makefile > CC ?= gcc > ./contrib/ip6range/Makefile As you can see you only found it in the contrib subdirs where makefiles have been copy-pasted from other directories from the beginning. Thanks for spotting these ones by the way, patch welcome to fix these as well. Willy
