Hi Pieter, On Sat, Sep 15, 2018 at 02:03:45AM +0200, PiBa-NL wrote: > Hi List, Willy, > > I've created a regtest that checks that when concurrent connections are > being handled that the connection counters are kept properly. > > I think it could be committed as attached. It takes a few seconds to run. It > currently fails on 1.9-dev2 (also fails on 1.8.13 with kqueue on FreeBSD, > adding a 'nokqueue' on 1.8.13 makes it succeed though..). > > I think it might be a good and reproducible test to run.? > > Or does it need more tweaking? Thoughts appreciated :).
I took some time this morning to give it a test. For now it fails here, after dumping 2200 lines of not really usable output that I didn't investigate. From what I'm seeing it seems to moderately stress the local machine so it has many reasons for failing (lack of source ports, improperly tuned conntrack, ulimit, etc), and it takes far too long a time to be usable as a default test, or this one alone will be enough to discourage anyone from regularly running "make reg-tests". I think we should create a distinct category for such tests, because I see some value in it when it's made to reproduce a very specific class of issues which is very unlikely to trigger unless someone is working on it. In this case it is not a problem that it dumps a lot of output, as it will be useful for the person knowing what to look for there. Probably that such tests should be run by hand and dump their log into a related file. Imagine for example that we would have this : $ make reg-tests/heavy/conn-counter-3000-req.log It would run the test on reg-tests/heavy/conn-counter-3000-req.vtc and would produce the log into reg-tests/heavy/conn-counter-3000-req.log. We could use a similar thing to test for select/poll/epoll/kqueue, to test for timeouts, race conditions (eg show sess in threads). This is very likely something to brainstorm about. You might have other ideas related to certain issues you faced in the past. Fred is unavailable this week but I'd be very interested in his opinion on such things. Thus for now I'm not applying your patch, but I'm interested in seeing what can be done with it. Thanks, Willy
