On 11/8/18 6:11 AM, Willy Tarreau wrote:
Hi guys,
On Wed, Nov 07, 2018 at 09:37:14AM +0100, Frederic Lecaille wrote:
New 'version' of the script attached.
It now supports a set of parameters to modify its behavior a little. And
also checking for a 'version requirement'. So a H2 test doesn't have to
fail on 1.7.
Very good work.
I missed this message last week (I'm not often on the list these days
I confess), but this tool is awesome!
Should i 'ask' to delete old test result.? Or would there be a other
better way to keep previous results separated from the current run?
No.
Rename the old vtc files like that before running the tests:
bname=$(basename $i)
mv /tmp/$bname /tmp/old.$bname
with $i in $(find /tmp/ -type d -name "vtc.*")
or something like that.
It would be nice to support TMPDIR so that we can force it in a script
instead of /tmp. What I *think* could be done by default would be to
delete the old.vtc.* files there before running the tests so that we
always keep only the last results by default. I found hundreds of vtc
directories in /tmp on my laptop and that can become problematic, even
worse on shared development machines.
please *add -type d* to the find command to list the temporary varnishtest
directories.
Well, then add -maxdepth 1 or 2 because you certainly don't want to run
find into my /tmp which contains complete distros to chroot into!
And we should only keep temporaries directory of tests which have failed
with -l varnishtest option currently enabled option. They are all the
/tmp/vtc.* directories found after having run the tests.
Interesting.
So the script should list the remaining temporary directories after having
run the tests. There is no need to parse the log file of this directories.
Then I'd like to see a small change, which would be that :
1) we rely on a user-provided base directory instead of /tmp, such as
${TMPDIR:-/tmp} since TMPDIR is very commonly defined ;
Pieter,
Note that varnishtest already uses TMPDIR variable in place of /tmp if
it is set in the environment.
Regards,
Fred
