On 1/9/19 10:12 AM, Willy Tarreau wrote:
On Tue, Jan 08, 2019 at 10:24:16AM +0100, flecai...@haproxy.com wrote:
  reg-tests/http-capture/h00000.vtc | 92 +++++++++++++++++++++++++++++++++++++++

Nice one, thanks Fred, now merged!

I'd be careful regarding expectations on log lines about stuff
that may evolve over time like the size below :

+    expect ~ "[^:\\[ ]\\[${h_pid}\\]: .* .* fe be/srv .* 200 17641 - - ---- .* .* 
{HPhx8n59qjjNBLjP} {htb56qDdCcbRVTfS} \"GET / HTTP/1\\.1\""
                                                                 ^^^^^

Since haproxy logs the exact byte count it received including headers,
and the status line, this may easily vary over time with minor changes
to varnishtest or to haproxy's muxes. I think that for such ones where
the exact could is neither predicted nor important, using a regex with
the order of magnitude should be enough and more robust over time (eg:
1 followed by 4 digits).

Yes, I agree. But I am curious to see when and the reason why this reg
test will be broken ;)

Fred.


Reply via email to