Hi Olivier,

On Sun, Jan 13, 2019 at 06:40:56PM +0100, Olivier Houchard wrote:
> > Indeed, this function should not have any special effect in this case,
> > it is needed to prepend this at the beginning of chk_report_conn_err() :
> > 
> >     if (!check->server)
> >             return;
> > 
> > We need to make sure that check->server is properly tested everywhere.
> > With a bit of luck this one was the only remnant.
> > 
> I'd rather just avoid calling dns_trigger_resolution() if there's no server,
> it seems it is the only use of check->server in chk_report_conn_err(), so
> that set_server_check_status() is call, and the check's status and result
> may be updated.

OK, that's fine with me as well, I hesitated between the two.

> Not sure it is really needed, but I'd rather not offend the Check Gods.


> The attached patches are updated to od just that.

Thank you. I'll merge them tomorrow. The ugliness of this code tells me
it's becoming urgent to perform a serious lifting to the whole checks
code :-/


Reply via email to