As for now it is stable, no looping. I'll leave it till monday and return
with feedback! :)

Thanks,

sob., 11.05.2019, 15:44 użytkownik Maciej Zdeb <mac...@zdeb.pl> napisał:

> Patch applied, finger crossed, testing! :-)
>
> Thanks!
>
> sob., 11 maj 2019 o 14:58 Willy Tarreau <w...@1wt.eu> napisał(a):
>
>> On Sat, May 11, 2019 at 11:01:42AM +0200, Willy Tarreau wrote:
>> > On Sat, May 11, 2019 at 10:52:35AM +0200, Willy Tarreau wrote:
>> > > I certainly made a few reasoning mistakes above but I don't see
>> anything
>> > > in the code preventing this case from happening.
>> > >
>> > > Thus I'd like you to try the attached patch which is supposed to
>> prevent
>> > > this scenario from happening. At least I've verified that it doesn't
>> > > break the h2spec test suite.
>> >
>> > While trying to check if it still applied to the latest 1.9 I figured
>> > that it corresponds to what Olivier had also found and fixed in his
>> > latest patch :-/  The positive point is that my analysis was correct.
>> >
>> > So I'm afraid that if it still fails with his fix, we'll need another
>> > core :-(
>>
>> Actually not, Olivier's fix is incomplete regarding the scenario I
>> proposed :
>> - in h2s_frt_make_resp_data() we can set H2_SF_BLK_SFCTL and remove the
>>   element from the list
>> - then in h2_shutr() and h2_shutw(), we check if the list is empty before
>>   subscribing the element, which is true after the case above
>> - then in h2c_update_all_ws() we still have H2_SF_BLK_SFCTL with the item
>>   in the send_list, thus LIST_ADDQ() adds it a second time.
>>
>> Thus the first part of the patch I sent is still required, I'm attaching
>> it
>> again, rebased on top of Olivier's patch and simplified so that we don't
>> detach then re-attach.
>>
>> I'm still keeping hope ;-)
>>
>> Willy
>>
>

Reply via email to