Hi Tim, On Wed, Jun 12, 2019 at 10:36:51PM +0200, Tim Duesterhus wrote: > Willy, > > First things first: > > Yes, I'm aware that this is shortly before 2.0. Either put this into 2.0 > or put this into `next` if you consider it too risky (or just wait until > 2.0 release before merging).
I had a quick look at your description. I'm shocked because I would have bet we already do emit Vary (and would have lost). The first approach is probably better as the second one can have a big impact on existing deployments by totally disabling any front-level cache when they are simple enough not to cache when there's a Vary header in the response. But the first one requires more head scratching to figure what possible impacts it could have. Given it has existed since the beginning, or at least 5 years, I think we can take our time to figure the best fix for it after the release. Could you please create an issue on github about it, and possibly link to this thread with your patches so that we don't forget it ? Thanks! Willy
