I can't comment about the patch itself, but wanted to comment about the
commit message.

Am 26.11.19 um 22:50 schrieb Илья Шипицин:
> Subject: [PATCH] CLEANUP: partially resolve #367

I believe this should be the 'BUILD' tag instead of CLEANUP. And I also
recommend to give a more descriptive subject line and move the issue
number into the body. This makes it easier to understand what the patch
is about without needing to reference the issue tracker.

May I suggest:

BUILD: Fix build for OpenSSL built with no-deprecated switch

> if OpenSSL is built with no-deprecated mode, some functions are not available.
> however, we keep those functions for LibreSSL when appropriate
Best regards
Tim Düsterhus

Reply via email to