On Wed, Nov 27, 2019 at 01:02:25AM +0100, Lukas Tribus wrote:
> Hello,
> 
> On Tue, Nov 26, 2019 at 10:50 PM ???? ??????? <chipits...@gmail.com> wrote:
> >
> > Hello,
> >
> > I resolved   `CRYPTO_set_id_callback', `ERR_remove_state', 
> > `SSL_CTX_set_ecdh_auto' issues.
> >
> >
> > the following two will be addressed later:  `X509_get_notBefore', 
> > `X509_get_notAfter'
> 
> I'm not sure if matching OPENSSL_NO_DEPRECATED is a good idea, for
> compatibility reasons (what's deprecated in one release isn't in
> another). It is also not immediately clear to me if those old code
> paths are needed by older openssl or not (or only libressl)?

It's a very good point. Somewhere else in this discussion there was a
suggestion about using OPENSSL_API_VERSION (or something like this).
It might be safer.

> Please allow *ample* time to review and test these patches before commit.

Noted, thanks!

Willy

Reply via email to