Hi Christopher, Thank you or updating the patch. I have seen the "http-check send" directive you have added in the patch and agree with your point that the syntax must be compatible with the rework in HTTP checks for H1/H2. As for the reg-test, sorry for my misinterpretation, I thought you wanted me to run the test suite to ensure that the patch doesn’t break any existing functionality. Nevertheless, I can now see that you have already created http-check-send.vtc and included it in the patch file.
So, I hope it is right for me to now presume that the patch is complete and there’s nothing actionable at my end. Please do let me know if any further action is required from my end in this regard. Thank You, Kiran Gavali -----Original Message----- From: Christopher Faulet [mailto:cfau...@haproxy.com] Sent: Thursday, April 9, 2020 1:17 PM To: Kiran Gavali <kiran.gav...@india.nec.com>; Willy Tarreau <w...@1wt.eu> Cc: haproxy@formilux.org; Shivharsh Singh <shivharsh.si...@india.nec.com>; Priya Ranjan <priya.ran...@india.nec.com>; Ramanpreet Singh Bakshi <ramanpreet.bak...@india.nec.com> Subject: Re: [RFC] BUG/MEDIUM: Checks: support for HTTP health checks with POST and data corrupted by extra connection close Le 08/04/2020 à 13:08, Kiran Gavali a écrit : > Hi Christopher And Willy, > > Please review the RT test results. > Hi, Sorry for the delay, I was fully busy on the tcp-check refactoring and had no brain time to work on this :) So, as said, the problem was not to support header and body addition to HTTP health checks but to use the good syntax. I'll rework the HTTP checks to support H1/H2 checks. And the syntax must be compatible. I attached a patch. It adds the "http-check send" directive. It is very close to your patch but the syntax should be compatible with the work I'll do on the http checks. at least I hope so. The "send" keyword may seem a bit strange but one idea of the refactoring is to support several request/response exchanges within the same HTTP check. Just a note about the reg-tests. My comment about it was not to run the testsuite but to add a specific reg-test to validate the feature. -- Christopher Faulet ________________________________ The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECTI or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECTI or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately.
