Jackie,
First: I'm a community contributor, so my review might not necessarily
reflect that of the HAProxy project. I'm also not a native English speaker.
Regarding your patch I have a few comments:
>From your PR message:
> Also, remove some trailing whitespaces from the files modified for funsies.
I disagree with this change. This makes the patch larger than it needs
to be and it distracts from the important parts of it. If anything it
should become a dedicated patch that is separately committed.
Regarding your commit messages:
Please have a look at the CONTRIBUTING file you modified. Commit
messages need to be prefixed with a "tag" ("DOC:" would probably be
appropriate) and also contain a body:
> As a rule of thumb, your patch MUST NEVER be made only of a subject line,
> it *must* contain a description. Even one or two lines, or indicating
> whether a backport is desired or not. It turns out that single-line commits
> are so rare in the Git world that they require special manual (hence
> painful) handling when they are backported, and at least for this reason
> it's important to keep this in mind.
(https://github.com/haproxy/haproxy/blob/f1ea47d8960730c79cc71fc634b3d7e5909d5683/CONTRIBUTING#L562-L567)
Then to the patch itself:
- It must not modify the license files doc/lgpl.txt and doc/gpl.txt,
because they are standard license texts:
https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html
- In lua.txt it now reads "They just works carefully". I believe it
should be "They just work carefully".
- In proxy-protocol.txt it now reads "to hide it's activities". I
believe it should be "to hide its activities".
Best regards
Tim Düsterhus
