Hi Ilya,

thanks for this. Two minor comments (just let me know, I can adjust
the patches before merging them if you confirm):

>    - os: linux
>      if: type == cron
>      compiler: clang
>      env: TARGET=linux-glibc LIBRESSL_VERSION=2.9.2 
> EXTRA_OBJS="contrib/prometheus-exporter/service-prometheus.o" CC=clang-9
> +    name: libressl-2.9.2 | prometheus-exporte

I guess this was "prometheus-exporter" above (missing "r") ?

> -  - make -j3 CC=$CC CPU_CFLAGS.generic="-O1" V=1 ERR=1 TARGET=$TARGET $FLAGS 
> DEBUG_CFLAGS="$DEBUG_CFLAGS" LDFLAGS="$LDFLAGS" ADDLIB="-Wl,-rpath,$SSL_LIB" 
> 51DEGREES_SRC="$FIFTYONEDEGREES_SRC" EXTRA_OBJS="$EXTRA_OBJS" $DEBUG_OPTIONS
> +  - make -j3 CC=$CC CPU_CFLAGS.generic="-O1" V=1 ERR=1 TARGET=$TARGET $FLAGS 
> DEBUG_CFLAGS="$DEBUG_CFLAGS" LDFLAGS="$LDFLAGS" $([ ! -z ${SSL_LIB+x} ] && 
> echo ADDLIB="-Wl,-rpath,$SSL_LIB") 51DEGREES_SRC="$FIFTYONEDEGREES_SRC" 
> EXTRA_OBJS="$EXTRA_OBJS" $DEBUG_OPTIONS

I did not notice this "-j3", shouldn't we use "-j$(nproc)" instead so
that we use all CPUs made available to us ?

Willy

Reply via email to