On Thu, Jul 30, 2020 at 08:25:16AM +0500, ???? ??????? wrote:
> > EXTRA_OBJS="contrib/prometheus-exporter/service-prometheus.o" CC=clang-9
> > > +    name: libressl-2.9.2 | prometheus-exporte
> >
> > I guess this was "prometheus-exporter" above (missing "r") ?
> >
> 
> oops.
> can you please fix it during merge ?

No problem, now fixed.

> > > -  - make -j3 CC=$CC CPU_CFLAGS.generic="-O1" V=1 ERR=1 TARGET=$TARGET
> > $FLAGS DEBUG_CFLAGS="$DEBUG_CFLAGS" LDFLAGS="$LDFLAGS"
> > ADDLIB="-Wl,-rpath,$SSL_LIB" 51DEGREES_SRC="$FIFTYONEDEGREES_SRC"
> > EXTRA_OBJS="$EXTRA_OBJS" $DEBUG_OPTIONS
> > > +  - make -j3 CC=$CC CPU_CFLAGS.generic="-O1" V=1 ERR=1 TARGET=$TARGET
> > $FLAGS DEBUG_CFLAGS="$DEBUG_CFLAGS" LDFLAGS="$LDFLAGS" $([ ! -z
> > ${SSL_LIB+x} ] && echo ADDLIB="-Wl,-rpath,$SSL_LIB")
> > 51DEGREES_SRC="$FIFTYONEDEGREES_SRC" EXTRA_OBJS="$EXTRA_OBJS" $DEBUG_OPTIONS
> >
> > I did not notice this "-j3", shouldn't we use "-j$(nproc)" instead so
> > that we use all CPUs made available to us ?
> >
> 
> it was a long ago, "-j3" appeared to be faster in my tests than $(nproc)
> (travis uses 2 cores).
> I do not have particular opinion. we can switch to $(nproc)

OK, I left it unchanged then.

Both patches merged, thank you!
Willy

Reply via email to