Hello Brad, On Sun, 13 Sep 2020 at 09:08, Brad Smith <b...@comstyle.com> wrote: > > The following diff updates the feature flags for Solaris / FreeBSD / NetBSD / > OpenBSD. > > Bump the baseline Solaris to 9 which intruduced closefrom(). > > FreeBSD 10 is already EOL for support but its the new baseline. Introduces > accept4(). > Enable getaddrinfo(). The FreeBSD port enables these. > > OpenBSD 6.3 is pretty old but it brings a compiler that supports TLS for the > threads > support. 5.7 already supported closefrom(). Enable getaddrinfo(). > > NetBSD 8.0 adds support for accept4() and closefrom(). Enable getaddrinfo().
We just had to disable threading on OpenBSD 6.7 for the build to succeed: https://github.com/haproxy/haproxy/issues/725 Did you actually test all those combinations? Because otherwise it does not seem like a good idea to commit this. Lukas
