Dear list! Author: alexzk1 <alexz...@gmail.com> Number of patches: 30
This is an automated relay of the Github pull request: SOCKS4(A) Patch title(s): trying to resolve server domain using SOCKS4A added htonl for IP fixed access to non-existing address more checks moved domen dump to backend fixed wrong paste in wrong file added error message updated error text made socks4 to use fake 10.10.10.10 moved struct socks4_request back to header as it could have alignment there added domain to debug out removed htonl call for fake ip fixed user_length added explicit #pragma pack added debug out of socks4a header added back htonl fixed userid, domain must follow it, not replace made single block send for socks4a updated debug text fixed "correction" removed extra if ()?: changed dumper to use unsigned char* updated debug text removed closing domain string in connection updated debug texts, added domain set to tcp check updated conn_set_domain to allow nullptr which just frees then, moved conn_set_domain in tcp_check as it can be couple cases updated debug text moved fake host definitions to separated file, made connection check for fake IP not conditional to debug updated debug output more text update Link: https://github.com/haproxy/haproxy/pull/883 Edit locally: wget https://github.com/haproxy/haproxy/pull/883.patch && vi 883.patch Apply locally: curl https://github.com/haproxy/haproxy/pull/883.patch | git am - Description: So I completely understand that you will dislike what my formatter did there, but you can just reject. I don't care as it was paid update. So what it do: 1. adds support for socks4A, if it cannot resolve dns localy it does ..read file "fake_host.h" 2. you forgot to copy-paste setup from "backend.c" to "tcpcheck.c" for socks4. So since 2.1 it does not do check over socks. I fixed that and removed copy-paste by doing function. Also it is generic rule, if any piece of code met twice -> do a function. 90% of your current can be changed in that way. 3. and at then end I have rhetoric question: if you invented there virtual functions and virtual table, why the hell you keep using C and don't switch to C++ ? Instructions: This github pull request will be closed automatically; patch should be reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is invited to comment, even the patch's author. Please keep the author and list CCed in replies. Please note that in absence of any response this pull request will be lost.
