Hello, On Wed, Sep 30, 2020 at 10:19:32PM +0200, PR Bot wrote: > Dear list! > > Author: alexzk1 <[email protected]> > Number of patches: 30 > > This is an automated relay of the Github pull request: > SOCKS4(A) (...) > Description: > So I completely understand that you will dislike what my formatter did > there, but you can just reject. I don't care as it was paid update.
I think it could win the contest of the funniest ever contribution received over the last two decades! First, I failed to spot a single patch that does something related to what the 2-to-8 words "commit message" claimed and this is not in any way the formatter's fault. Second, claiming "I don't care if you pick it anyway since I was paid to do it" makes me wonder "who's crazy enough to pay for this, and probably to go as far as deploying it?". I mean, I'm not sure they realized they'll have to pay you to do it again and again after each fix that gets applied to the main tree. Well done at least if that worked :-) > So what it do: > 1. adds support for socks4A, if it cannot resolve > dns localy it does ..read file "fake_host.h" > 2. you forgot to > copy-paste setup from "backend.c" to "tcpcheck.c" for socks4. So since > 2.1 it does not do check over socks. > I fixed that and removed > copy-paste by doing function. If you have a fix to provide, please point it in this ocean of random patches, because I can't find it. Or better, just explain what the problem is so that someone can fix it properly :-/ > Also it is generic rule, if any > piece of code met twice -> do a function. 90% of your current can be > changed in that way. Excellent advice, thank you! > 3. and at then end I have rhetoric question: > if you invented there virtual functions and virtual table, why the > hell you keep using C and don't switch to C++ ? Hehe good one :-) Willy
