Hi, On Sun, Dec 20, 2020 at 12:58:52PM +0500, ???? ??????? wrote: > ping :)
Oh I completely missed this one in the noise it seems! I'm sorry. > > Author: Christian Ruppert <id...@qasl.de> > > Number of patches: 1 > > > > This is an automated relay of the Github pull request: > > hpack-tbl-t.h uses VAR_ARRAY and requires compiler.h to be included I initially tried hard not to put haproxy-specific dependencies in these protocol-specific parts so that they could easily be reused by other projects if needed (hence the relaxed MIT license). But I guess adding compiler.h is not that big of a deal. However I disagree with including it from the same directory with double-quotes, as we try to keep our includes more or less ordered with certain dependencies. Thus Christian, I can offer 3 possibilities here, I don't know which one best suits your use case: 1) we include <haproxy/compiler.h> from this file. It will best follow the current practices all over the code, but may or may not work for your use case depending how you include the file; 2) we include <haproxy/api.h> from this file so that it becomes consistent with everything else ; 3) we add the ifdef VAR_ARRAY directly into the file so that it continues not to depend on anything and can be directly imported into other projects as needed. I guess I prefer the 3rd option here as it's extremely cheap and will keep external build setups very straightforward. What do you think ? Thanks! Willy