No Problem at all. Feel free :)
On 2020-12-21 12:59, Willy Tarreau wrote:
On Mon, Dec 21, 2020 at 12:20:36PM +0100, Christian Ruppert wrote:
> 2) we include <haproxy/api.h> from this file so that it becomes
> consistent
> with everything else ;
>
> 3) we add the ifdef VAR_ARRAY directly into the file so that it
> continues
> not to depend on anything and can be directly imported into other
> projects as needed.
>
> I guess I prefer the 3rd option here as it's extremely cheap and will
> keep external build setups very straightforward. What do you think ?
>
> Thanks!
> Willy
2. and 3. sounds good. 3. however seems to be the best solution,
indeed.
OK, do you mind if I just modify your patch and commit message
according
to this ? Or do you prefer to send a new one ? I'm asking because while
I usually have no problem modifying patches or commit messages, I don't
do it when they're signed.
Thanks,
Willy
--
Regards,
Christian Ruppert