> I am not sure we will import the second patch for the reg test: it makes usage of curl. We try to not use external programs for reg tests except if there is no choice.
Fine by me. I actually meant to say that my second attempt at writing a reg attempt should replace that patch. Apparently I forgot. Thayne McCombs Senior Software Engineer [email protected] <https://www.golucid.co/> Lucid.co <http://lucid.co> On Tue, Dec 29, 2020 at 2:52 AM Frederic Lecaille <[email protected]> wrote: > On 12/19/20 9:07 AM, Thayne McCombs wrote: > > From 731d6a00f3cf0c70d7a8a916e1984c225f3a9dd6 Mon Sep 17 00:00:00 2001 > > From: Thayne McCombs <[email protected]> > > Date: Sat, 19 Dec 2020 00:59:35 -0700 > > Subject: [PATCH] Add test for stickiness using the server address for the > > server key > > > > --- > > reg-tests/stickiness/srvkey-addr.vtc | 259 +++++++++++++++++++++++++++ > > 1 file changed, 259 insertions(+) > > create mode 100644 reg-tests/stickiness/srvkey-addr.vtc > > > > diff --git a/reg-tests/stickiness/srvkey-addr.vtc > > b/reg-tests/stickiness/srvkey-addr.vtc > > new file mode 100644 > > index 000000000..b5675089f > > --- /dev/null > > +++ b/reg-tests/stickiness/srvkey-addr.vtc > > @@ -0,0 +1,259 @@ > > +vtest "A reg test for stickiness with srvkey addr" > > +feature ignore_unknown_macro > > + > > + > > +# The aim of this test is to check that "stick on" rules > > +# do the job they are supposed to do. > > +# If we remove one of the "stick on" rule, this script fails. > > + > > +#REQUIRE_VERSION=2.0 > > Ok for this test but I think we should use 2.4 which is the current > developemnt version. > > Willy, I think we can import this patch after having merged the previous > one [1/2] patch about this feature implementation. >
