On 12/16/20 8:39 AM, Thayne McCombs wrote:
On 12/10/20 1:31 AM, Frederic Lecaille wrote:
It would be preferable to send all your patches, so that others than me
may review your work (no diff between different versions of patches) and
continue to split your work in several patches.
Ok, here is what I have so far as two patches (I combined feedback into the
original commit):
Hello Thayne,
You work sounds perfect to me.
I am not sure we will import the second patch for the reg test: it makes
usage of curl. We try to not use external programs for reg tests except
if there is no choice. This is not the case here.
Willy, could you have a look at the first patch, especially sa2str()
implementation. I have doubt about its portability:
const int max_length = sizeof(struct sockaddr_un) - offsetof(struct
sockaddr_un, sun_path) - 1;
return memprintf(&out, "abns@%.*s", max_length, path+1);
As far as I see, everywhere that unix socket are used in haproxy code,
we consider ->sun_path as NULL terminated.
