Willy,

On 12/25/21 11:10 AM, Willy Tarreau wrote:
That's a good idea. I cannot judge if the method is correct but the
less errors we produce on early failures, the better. I think Tim told
me he would be out of reach these days for reviews. Do you confirm you've
tested it ? If so I can merge it now.

Not completely unvailable, just less available (and not touching anything $dayjob related) :-)

The patch looks good to me in general, but I don't think the 'if: ${{ !failure() }}' are needed, because they are implicit.

The only change required should be the one at the bottom, changing

if: ${{ failure() }}

to

if: ${{ failure() && steps.vtest.outcome == 'failure' }}

Best regards
Tim Düsterhus

Reply via email to