On Sat, Dec 25, 2021, 4:14 PM Willy Tarreau <[email protected]> wrote: > On Sat, Dec 25, 2021 at 01:53:54PM +0100, Tim Düsterhus wrote: > > Willy, > > > > On 12/25/21 11:10 AM, Willy Tarreau wrote: > > > That's a good idea. I cannot judge if the method is correct but the > > > less errors we produce on early failures, the better. I think Tim told > > > me he would be out of reach these days for reviews. Do you confirm > you've > > > tested it ? If so I can merge it now. > > > > Not completely unvailable, just less available (and not touching anything > > $dayjob related) :-) > > hehe :-) > > > The patch looks good to me in general, but I don't think the 'if: ${{ > > !failure() }}' are needed, because they are implicit. > > > > The only change required should be the one at the bottom, changing > > > > if: ${{ failure() }} > > > > to > > > > if: ${{ failure() && steps.vtest.outcome == 'failure' }} > > OK thanks for your review. Ilya, are you interested in giving this one a > try ? Alternately I can merge it as is and we'll later focus on this as a > cleanup. It's up to you guys, let me know what you prefer, I don't want > to waste your Xmas day. >
Let's merge as is. I'll test changes later. Anyway, I've figured out how to enable cache and there will be patches later > > Thanks! > Willy >
