On Tue, Aug 23, 2022 at 10:37:28PM -0400, Brad Smith wrote: > On 8/23/2022 10:22 PM, Willy Tarreau wrote: > > Hi Brad, > > > > On Sat, Aug 13, 2022 at 11:25:32PM -0400, Brad Smith wrote: > > > I'm not sure if MINOR is right. Currently the build is broken since > > > TCP_INFO > > > was added. > > Just to be certain, you mean the build is broken without your patch or > > with it ? If it's broken without, it means that your patch is a build > > fix, but it also indicates there's something wrong in the whole code's > > arrangement there that we'll have to re-adjust, because we must not > > break things for operating systems that are not explicitely handled. > > The build is broken without the diff. I was looking at older releases and > this > only affects 2.7 and 2.6. > > It looks like this changed things in such a way that if TCP_INFO is added > but the OS is not added to the list of OS's it will not build. > > http://git.haproxy.org/?p=haproxy-2.6.git;a=commitdiff;h=5c83e3a1563cd7face299bf08037e51f976eb5e3;hp=39e436e222236c4e6c0efe95c304fe89fd01e111
Oh I see... What a mess! Thanks for the clarifiation. I'll merge your patch as a build fix and with such indications. It's suitable for backporting. As a next step for 2.7 and further, we should change this to have a new USE_TCP_INFO build options that will be set by default in the makefile for supported operating systems and tested instead of testing all OS combinations. If you want to work on this, you're welcome :-) Thanks! Willy
