Christopher, thanks for you review, I’m only saving general approach to the 
indentation and to follow it I need to move other lines …

User passes some check port to the `backed.server` line and I want to provide 
this port to the external-check script. Because for an example when we’re using 
haproxy as a loadbalancer for our Kubernetes service, we have service port + 
healthcheck port and our external-check script should balance traffic on 
service port but send availability requests to the healtcheck port => but 
currently external-check don’t have any variants to receive this check port 
from check directive of the `backed.server` line.

От: Christopher Faulet <cfau...@haproxy.com>
Дата: пятница, 24 ноября 2023 г. в 10:45
Кому: Payne Max <yardalge...@gmail.com>, haproxy@formilux.org 
<haproxy@formilux.org>
Тема: Re: [PATCH] Add HAPROXY_SERVER_CHECK_PORT to the external check
Le 24/11/2023 à 10:16, Payne Max a écrit :
> Hi folks!
> I've found a problem that really locks my team so the problem that external
> check don't have any opportunity to receive server check port  and can work 
> only
> with server's main port.
>
> So I've made several small changes in and looks at least partially I can build
> an app inside ubuntu container on my Mac.
>
> Can anyone help me with contribution of this feature? Added a snippet with my
> changes above.
>

Hi,

There is an indentation issue with your patch. Thus it is pretty hard to review
because real changes are mix up with indent changes.

However, I don't understand what you want to achieve. If you are using an
externel-check, there is no TCP health-check. The check port is useless in this
case.

--
Christopher Faulet

Reply via email to