Hi David, On Thu, Jan 25, 2024 at 09:26:24AM +0000, David Carlier wrote: > Finally the last piece related to the da's dummy update and da.c changes.
Thanks. I'm getting the following build error: addons/deviceatlas/da.c: In function 'da_haproxy_checkinst': addons/deviceatlas/da.c:284:25: warning: implicit declaration of function 'da_getdatacreationiso8601'; did you mean 'da_getdatacreation'? [-Wimplicit-function-declaration] addons/deviceatlas/da.c:283:31: warning: format '%s' expects argument of type 'char *', but argument 2 has type 'int' [-Wformat=] addons/deviceatlas/da.c: At top level: addons/deviceatlas/da.o: In function `da_haproxy_checkinst': .../addons/deviceatlas/da.c:283: undefined reference to `da_getdatacreationiso8601' collect2: error: ld returned 1 exit status distcc[22474] ERROR: compile (null) on localhost failed Makefile:999: recipe for target 'haproxy' failed make: *** [haproxy] Error 1 I tried with this: USE_DEVICEATLAS=1 DEVICEATLAS_SRC=addons/deviceatlas/dummy and this: USE_DEVICEATLAS=1 DEVICEATLAS_SRC=addons/deviceatlas/dummy DEVICEATLAS_NOCACHE=1 And indeed, there's an inconsistency there: $ git grep da_getdatacreation addons/deviceatlas/da.c: da_getdatacreationiso8601(&global_deviceatlas.atlas)); addons/deviceatlas/dummy/dac.c:da_getdatacreation(da_atlas_t *atlas) addons/deviceatlas/dummy/dac.h:time_t da_getdatacreation(da_atlas_t *atlas); Could you please recheck ? Thanks, Willy