On Fri, Jan 26, 2024 at 06:35:09PM +0000, David Carlier wrote: > > > > It broke the CI on the "all features" build: > > > > > > https://github.com/haproxy/haproxy/actions/runs/7671640626/job/20910459829 > > > > /usr/bin/ld: cannot find -lcurl: No such file or directory > > /usr/bin/ld: cannot find -lzip: No such file or directory > > > > I'm surprised because CURL_LDFLAGS and LDFLAGS didn't change from the > > previous > > one: > > > > -CURL_LDFLAGS := $(shell $(CURL_CONFIG) --libs 2>/dev/null || echo -L > > /usr/local/lib -lcurl) > > -LDFLAGS += $(CURL_LDFLAGS) $(PCRE2_LDFLAGS) -lz -lzip -lpthread > > > > +CURL_LDFLAGS := $(shell $(CURL_CONFIG) --libs 2>/dev/null || echo -L > > /usr/local/lib -lcurl) > > +OPTIONS_LDFLAGS += $(CURL_LDFLAGS) -lz -lzip -lpthread > > > > I guess it's definitely because these libs are not in the VM, and maybe > > they'll either need to be added or we need to make it possible to disable > > them (particularly if they were not needed previously), but if you could > > figure why it used to work previously, that would be great. > > > > > > > OK that's it, the flags were only used to build "dadwsch". > > > > Yes indeed that s exactly it, the module does not use curl capabilities to > function, its optional > ans I see we do not compile the optional compilation unit for it anyway. > You guessed it right.
Fine, I've pushed it and we'll see. I'm confident now ;-) Willy