Mikhail Fursov wrote:
6)
Does GCV4 work with jit_gc.diff?
Yes. The rootset reported by JIT is the same. The only change is that
instead of the method 'enumerate(mptr, base)' JIT uses the method
'enumerate(mptr, offset)' that was used before only for mptrs with static
offsets (offsets known during compilation of a method)
Why do we care abouve GCv4?
7)
Instead of applying jit_gc.diff what about applying
retrieve_root_set.diff?
If it is now too hard to rollback SVN, how about reopening JIRA1862 and
also
applying retrieve_root_set.diff also? The rationale is that there has
not
been adequate discussion on modifying the semantics of JIT/GC interface.
I vote not to rollback JIT patch. JIT is more flexible with this patch
without any additional cost. The code is slightly increased (4-6 lines)
but
it makes debugging simpler :)
8)
Note that retrieve_root_set.diff does not impact JIT/VM/GC
interfaces. It
is only local to gcv4.1. Also note retrieve_root_set.diff patch line
count
is 13 and jit_gc.diff line count is 179.
In the JIT patch I cleaned unused enumeration methods from JIT interface,
added comments and replaced the one large loop with two of smaller
size(precaching, reporting). The real number of new lines is less than 10.
So IMO the correct fix for this problem is in the trunk. GC has cmd-line
option to disable object moving during the enumeration and it's enough.
Weldon, clearly this modification is a problem for you. Why?
geir
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
