[
https://issues.apache.org/jira/browse/HBASE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585143#action_12585143
]
Jim Kellerman commented on HBASE-71:
------------------------------------
I looked at the flow again and now I understand how it works. Comments helped.
Thanks!
Overall I think this is a great patch and I think the test case is also very
good. I have a couple of minor questions, and a bunch of nits. +1 when they are
addressed.
Q: Are the regions displayed by regionserver.jsp sorted?
Q: RegionManager.regionsAwaitingAssignment return Set. Why not List?
Nits (but unfortunately necessary)
Need javadoc for LocalHbaseCluster
- waitForServerOnline
- removeRegionServer
HMasterRegionInterface needs updated javadoc for regionServerReport
master.ProcessRegionClose needs updated javadoc for constructor.
RegionManager:
- unused imports: java.util.concurrent.BlockingQueue,
java.util.concurrent.LinkedBlockingQueue, java.util.HashMap
- unassignSomeRegions variable serverName is not read.
- stopScanners should be javadoc and not just a comment
- getFirstMetaRegionForRegion last else is not necessary
- incorrect or incomplete javadoc for waitForMetaRegionsOrClose,
getFirstMetaRegionForRegion, getMetaRegionsForTable, createRegion,
waitForMetaRegionsOrClose, putMetaRegionOnline, getListOfOnlineMetaRegions,
numOnlineMetaRegions, isMetaRegionOnline, offlineMetaRegion, isUnassigned,
isPending, setUnassigned, setPending, noLongerPending,
updateAssignmentDeadline, noLongerUnassigned, markToClose, markToCloseBulk,
getMarkedToClose, isMarkedToClose, noLongerMarkedToClose, isClosing,
noLongerClosing, setClosing, addMetaRegionToScan, markRegionForDeletion,
regionDeleted, markRegionForOffline, isMarkedForOffline, regionOfflined,
isMarkedForDeletion, isInitialRootScanComplete, isInitialMetaScanComplete,
getRootRegionLocation, waitForRootRegionLocation, numMetaRegions,
incrementNumMetaRegions, setRootRegionLocation, setNumMetaRegions
ServerManager:
- Javadoc for regionServerReport, getAverageLoad should be updated.
HRegionServer:
- unused import java.util.SortedMap
- method isOnline needs javadoc
MiniHBaseCluster:
- unused import o.a.h.h.utilFSUtils
- fix javadoc for constructor
> [hbase] Master should rebalance region assignments periodically
> ---------------------------------------------------------------
>
> Key: HBASE-71
> URL: https://issues.apache.org/jira/browse/HBASE-71
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: master
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.2.0
>
> Attachments: 71-v2.patch, 71-v3.patch, 71-v4.patch, 71.patch
>
>
> The master currently only does region assignments at startup or when there
> are splits or dead regionservers. This means that if you join a new
> regionserver to the cluster after startup, it does not get assigned a fair
> share of the already-served regions as you would expect. It only gets a share
> of new regions being served.
> The master should periodically check the balance of regions, based on
> whatever assignment function, instead of in reaction to the above listed
> events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
