[ 
https://issues.apache.org/jira/browse/HBASE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585191#action_12585191
 ] 

Jim Kellerman commented on HBASE-71:
------------------------------------

Sorry, couple of more nits. Unfortunately Eclipse does not reveal them all at 
once, but as others are fixed, more appear. Hopefully these are the last. Will 
run regression suite after my run for 0.1.1 completes, since these few comment 
changes are not going to affect the results.

ProcessRegionClose constructor is missing @param master in javadoc

RegionManager:
- regionsBeingReassigned is never read. Is it necessary.
- line 231: unnecessary check for null
- waitForMetaRegionsOrClose does not throw IOException, can be removed. No 
@return javadoc
- createRegion no @throws in javadoc
- addMetaRegionToScan no @throws in javadoc

MiniHBaseCluster
- no @throws in javadoc for constructor

> [hbase] Master should rebalance region assignments periodically
> ---------------------------------------------------------------
>
>                 Key: HBASE-71
>                 URL: https://issues.apache.org/jira/browse/HBASE-71
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.0
>
>         Attachments: 71-v2.patch, 71-v3.patch, 71-v4.patch, 71-v5.patch, 
> 71.patch
>
>
> The master currently only does region assignments at startup or when there 
> are splits or dead regionservers. This means that if you join a new 
> regionserver to the cluster after startup, it does not get assigned a fair 
> share of the already-served regions as you would expect. It only gets a share 
> of new regions being served.
> The master should periodically check the balance of regions, based on 
> whatever assignment function, instead of in reaction to the above listed 
> events.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to