[
https://issues.apache.org/jira/browse/HBASE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589726#action_12589726
]
stack commented on HBASE-532:
-----------------------------
Thanks Jim and Bryan for review. I did all suggestions except following:
> Rename "ss" parameter in clearSnapshot to something like oldSnapshot? Would
> be a little clearer to read at a glance.
Left it as it was. oldSnapshot is not correct -- there is no 'old' snapshot
only the current snapshot -- and can't call it snapshot cos it clashes with
data member.
> Should get() create a list and pass it into both calls of internalGet? Would
> save us an object creation.
Nah. Keep that stuff local in the method rather than have client supply it.
If it were an object of some size, then yeah.
> The private version of getNextRow should probably be called
> internalGetNextRow to follow the pattern of the rest of the methods in
> Memcache.
Its the other methods that are incorrectly named w/ their internal prefix.
Marking method private should be sufficient to indicate internal-ness.
> In next, the nested condition starting on 116 is gigantically miserable.
> Maybe it should be factored out into one or more methods? It would improve
> readability and capture the essence of what you're trying to do.
I'm afraid to touch it.
> Odd interaction between HRegion.get, HRegion.deleteAll and compactions
> ----------------------------------------------------------------------
>
> Key: HBASE-532
> URL: https://issues.apache.org/jira/browse/HBASE-532
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.1.1
> Reporter: Jim Kellerman
> Assignee: stack
> Priority: Blocker
> Fix For: 0.2.0, 0.1.2
>
> Attachments: 532.patch
>
>
> If you apply the patch for HBASE-483 to the 0.1 branch and comment out lines
> 309 and 315 of MetaUtils.java (which force compactions of the root and meta
> regions respectively), TestMergeTool fails. Why forcing compactions makes the
> test succeed is a mystery to me.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
