[
https://issues.apache.org/jira/browse/HBASE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588876#action_12588876
]
Bryan Duxbury commented on HBASE-532:
-------------------------------------
* If shapshot() is called and there's still entries in the snapshot, I think
I'd prefer an exception right then instead of the last snapshot. That way we
won't silently forget to call clearSnapshot anywhere.
* Why should caller of clearSnapshot provide the snapshot back in? Afraid
someone will try and clear the wrong snapshot somehow?
* Is this worth an edit? Moreover, do we need the explicit "this." all over
the place? (This might be a general stylistic question.)
{{{code}}}
- memcache.put(key, value);
-
+ this.memcache.put(key, value);
{{{code}}}
* There's a note in getNextRow that it's not suppressing deletes. It should,
shouldn't it? Otherwise we risk saying the wrong row is the next one. Could
create some confusion.
* What's this do?
{{{code}}}
- found_key.getTimestamp());
+ Long.valueOf(found_key.getTimestamp()));
{{{code}}}
... more to come.
> Odd interaction between HRegion.get, HRegion.deleteAll and compactions
> ----------------------------------------------------------------------
>
> Key: HBASE-532
> URL: https://issues.apache.org/jira/browse/HBASE-532
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.1.1
> Reporter: Jim Kellerman
> Assignee: stack
> Priority: Blocker
> Fix For: 0.2.0, 0.1.2
>
> Attachments: 532.patch
>
>
> If you apply the patch for HBASE-483 to the 0.1 branch and comment out lines
> 309 and 315 of MetaUtils.java (which force compactions of the root and meta
> regions respectively), TestMergeTool fails. Why forcing compactions makes the
> test succeed is a mystery to me.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
