[
https://issues.apache.org/jira/browse/HBASE-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-586:
------------------------
Attachment: 586.patch
Here is first cut. Merge is failing for some odd reason so need to fix that.
Also want to run this on cluster because its there where will figure if new
technique actually works.
{code}
HBASE-586 HRegion runs HStore memcache snapshotting -- fix it so HRegion only
knows about flushing
Make it so region does not know about store memcaches any more. It
just knows about flushes. Runs flushes, not flushes and memcache snapshots
individually. Makes things a tad less complicated.
M src/test/org/apache/hadoop/hbase/util/TestMergeTool.java
Catch and report error if one running merge.
M src/java/org/apache/hadoop/hbase/regionserver/HStore.java
(snapshotMemcache): Removed.
(flushCache): Added return of size flushed.
M src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
(flushCache): Just call internalFlushcache.
(snapshotMemcaches): Removed.
(internalFlushcache): No longer take a 'starttime'.
In here do things too like set the flushRequested flag and
last flush time rather than over in the removed
snapshotMemcaches. Also, decrement memcacheSize by the
amount of data flushed.
(getEntrySize): Utility method.
M ndex: src/java/org/apache/hadoop/hbase/util/Merge.java
Catch problems earlier.
{code}
> HRegion runs HStore memcache snapshotting -- fix it so HRegion only knows
> about flushing
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-586
> URL: https://issues.apache.org/jira/browse/HBASE-586
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: 586.patch
>
>
> HRegion needs to keep count of memcache sizes. Currently its trying to run
> the memcaches snapshots so it can keep up this number. HRegion should know
> nothing about no memcache snapshotting -- should be internal to flushing ...
> especially since HBASE-532 fix. HRegion can ask for store sizes.... Add
> that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
