[ 
https://issues.apache.org/jira/browse/HBASE-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591079#action_12591079
 ] 

Jim Kellerman commented on HBASE-586:
-------------------------------------

Don't understand this part of javadoc for Memcache.getSnapshot:
{code}
   * Called by flusher when it wants to clean up snapshot made by a previous
   * call to [EMAIL PROTECTED] snapshot}
{code}

Otherwise +1


> HRegion runs HStore memcache snapshotting -- fix it so only HStore knows 
> about workings of memcache
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-586
>                 URL: https://issues.apache.org/jira/browse/HBASE-586
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 0.2.0
>
>         Attachments: 586-v2.patch, 586-v3.patch, 586.patch
>
>
> HRegion needs to keep count of memcache sizes.  Currently its trying to run 
> the  memcaches snapshots so it can keep up this number.  HRegion should know 
> nothing about no memcache snapshotting -- should be internal to flushing ... 
> especially since HBASE-532 fix.   HRegion can ask for store sizes....  Add 
> that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to