[
https://issues.apache.org/jira/browse/HBASE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594063#action_12594063
]
stack commented on HBASE-478:
-----------------------------
Jim: Can you fix the patch. Seems like most of it is you adding ^M. For
example:
{code}
Index: src/java/org/apache/hadoop/hbase/HStore.java
===================================================================
--- src/java/org/apache/hadoop/hbase/HStore.java (revision 652949)
+++ src/java/org/apache/hadoop/hbase/HStore.java (working copy)
@@ -85,7 +85,7 @@
// The currently active sorted map of edits.
private volatile SortedMap<HStoreKey, byte[]> mc =
createSynchronizedSortedMap();
-
+
// Snapshot of memcache. Made for flusher.
private volatile SortedMap<HStoreKey, byte[]> snapshot =
createSynchronizedSortedMap();
@@ -126,43 +126,43 @@
}
}
- /**
- * Return the current snapshot.
- * Called by flusher when it wants to clean up snapshot made by a previous
+ /**
+ * Return the current snapshot.
+ * Called by flusher when it wants to clean up snapshot made by a previous
* call to [EMAIL PROTECTED] snapshot}
- * @return Return snapshot.
- * @see [EMAIL PROTECTED] #snapshot()}
- * @see [EMAIL PROTECTED] #clearSnapshot(SortedMap)}
- */
- SortedMap<HStoreKey, byte[]> getSnapshot() {
- return this.snapshot;
- }
+ * @return Return snapshot.
+ * @see [EMAIL PROTECTED] #snapshot()}
+ * @see [EMAIL PROTECTED] #clearSnapshot(SortedMap)}
+ */
+ SortedMap<HStoreKey, byte[]> getSnapshot() {
+ return this.snapshot;
+ }
{code}
Above is from the head of the patch and nothing of substance has been changed.
Makes it hard to review. Thanks.
> offlining of table does not run reliably
> ----------------------------------------
>
> Key: HBASE-478
> URL: https://issues.apache.org/jira/browse/HBASE-478
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.1.2, 0.1.1
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Critical
> Fix For: 0.1.2
>
> Attachments: 478-0.1.patch
>
>
> I have a table of 4 regions made w/ PE. I cannot reliably offline it. I'm
> using 'disable TestTable' and have traced it to ensure its not a problem in
> hql. What I see is that one region will get the offlined mark or maybe
> two.. but never all.
> Jim in IRC suggested that if we did the .TABLE. catalog table, offlining the
> entry there might be more reliable than trying to offline all regions in a
> table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
