[
https://issues.apache.org/jira/browse/HBASE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594270#action_12594270
]
stack commented on HBASE-478:
-----------------------------
Thanks for removing white-space differences.
Following is not important.
To avoid confusion, I'd suggest in future that we act on the IDE's suggestion
and rename these fields in the subclass. My sense is that subclasses with data
members of the same name as members of their parent class will for sure burn
someone refactoring or debugging.
{code}
+ @SuppressWarnings("hiding")
private MapFile.Reader[] readers;
// Used around replacement of Readers if they change while we're scanning.
+ @SuppressWarnings("hiding")
private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
{code}
You removed table delete from TestHBaseCluster. It'd be too hard to add
enable/delete? It'd be hard asserting enable state? Disabled state? If you
could assert disabled state, maybe add back delete? I just suggest this
because this facility -- enabling/disabling table is critical to hbase admin
and can't be broken going forward (I can't believe we got this far w/o clammer
for this fix -- smile).
Will be back after test has finished.
> offlining of table does not run reliably
> ----------------------------------------
>
> Key: HBASE-478
> URL: https://issues.apache.org/jira/browse/HBASE-478
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.1.2, 0.1.1
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Critical
> Fix For: 0.1.2
>
> Attachments: 478-0.1-v2.patch, 478-0.1.patch
>
>
> I have a table of 4 regions made w/ PE. I cannot reliably offline it. I'm
> using 'disable TestTable' and have traced it to ensure its not a problem in
> hql. What I see is that one region will get the offlined mark or maybe
> two.. but never all.
> Jim in IRC suggested that if we did the .TABLE. catalog table, offlining the
> entry there might be more reliable than trying to offline all regions in a
> table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
