[ 
https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622634#action_12622634
 ] 

Toby White commented on HBASE-697:
----------------------------------

>From a brief review, this looks fine to me - but I'm not familiar with most of 
>the HBase API, so don't take my word for it.

Certainly it serves my purposes well enough - I can now retrieve timestamps & 
delete tables.

A minor thing - the new thrift jar attached requires a newer version of java 
than I have on this computer (1.5.0_13), but I've run into no problems using 
the old thrift jar.

As a side issue, I've attached another patch for ThriftServer.java (apply on 
top of Tim's patch) to HBASE-657, which should probably be rolled into this.

> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
>                 Key: HBASE-697
>                 URL: https://issues.apache.org/jira/browse/HBASE-697
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: stack
>            Assignee: Bryan Duxbury
>             Fix For: 0.2.1
>
>         Attachments: HBASE-697.patch, hbase-timestamps.patch, 
> libthrift-20080411p1.jar
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to