[
https://issues.apache.org/jira/browse/HBASE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622922#action_12622922
]
stack commented on HBASE-697:
-----------------------------
Toby: Is it because the jar up on facebook was compiled w/ a 1.6JVM? I tried
downloading and recompiling w/ 1.5 JVM. Generated jar is suspiciously small.
The content of this package, com/facebook/thrift/processor/, is missing from my
built jar. Agreed that the thing should run w/ a 1.5JVM if that is the issue
since rest of hbase is based on 1.5 but I wouldn't put this in way of a commit.
Should I go with Tim's patch and just leave the old thrift jar for now? That
works for you Toby and Tim?
Should Imake issue to add unit tests for HBaseHandler? IIRC, you don't have to
put up thrift servers to exercise this class so should be easy to add.
Tim: Looking at patch, ignoring the generated code (yuck), DemoClient contains
a class named 'CopyOfDemoClient'. Thats a little odd (I can fix on commit if
you like). And you don't have RowResult or a RowResult-like thing in your IDL.
Not needed? The thrift package.html hasn't been updated (I can do that on
commit too). Otherwise, patch looks great.
Good stuff lads.
> thrift idl needs update/edit to match new 0.2 API (and to fix bugs)
> -------------------------------------------------------------------
>
> Key: HBASE-697
> URL: https://issues.apache.org/jira/browse/HBASE-697
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: stack
> Assignee: Bryan Duxbury
> Fix For: 0.2.1
>
> Attachments: HBASE-697.patch, hbase-timestamps.patch,
> libthrift-20080411p1.jar
>
>
> Talking w/ Bryan, moving this out of the way of the 0.2.0 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
