[
https://issues.apache.org/jira/browse/HBASE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-953:
------------------------
Attachment: blockcache.patch
Commit comment below
{code}
HBASE-953 Enable BLOCKCACHE by default [WAS -> Reevaluate HBASE-288 block
caching work....?]
Change that makes BLOCKCACHE on by default but caching blocks of 16k rather
than 64k.
Means that upgrading, users must update their hbase-default.xml to pick up the
smaller
value else OOME issues. This patch may introduce OOME issues anyways. Need to
watch
out for it (Was find on 1.6.0_10 but on an early 1.7.0 was easy to OOME).
This patch removes commons-collections.jar. Was only added for its
ReferenceMap which
is replaced in this patch by a version of what used to be called SoftSortedMap
(renamed
as SoftValueSortedMap); the ReferenceMap replacement is SoftValueMap. Use our
own
because I want to be able to watch evictions if issues with OOMEs and RM is all
private
when it runs the ReferenceQueue clean up (RM also had features we don't need).
M conf/hbase-default.xml
Update hbase.hstore.blockCache.blockSize; make 16k instaed of 64k.
D lib/commons-collections-3.2.jar
Removed. Not used.
A src/test/org/apache/hadoop/hbase/util/SoftValueSortedMapTest.java
Rename of SoftSortedMapTest.
D src/test/org/apache/hadoop/hbase/util/SoftSortedMapTest.java
Removed
M src/java/org/apache/hadoop/hbase/HColumnDescriptor.java
Enable blockcaching as default.
M src/java/org/apache/hadoop/hbase/io/BlockFSInputStream.java
Use SoftValueMap instead of ReferenceMap.
A src/java/org/apache/hadoop/hbase/util/ReferenceQueueUtil.java
ReferenceQueue utility class.
A src/java/org/apache/hadoop/hbase/util/SoftValueMap.java
Like SoftValueSortedMap but not sorted (based on it).
A src/java/org/apache/hadoop/hbase/util/SoftValue.java
Added. Was internal class of SoftSortedMap.
A src/java/org/apache/hadoop/hbase/util/SoftValueSortedMap.java
Rename of SoftSortedMap.
A src/java/org/apache/hadoop/hbase/util/SoftSortedMap.java
Like SoftValueSortedMap but a plain Map.
M src/java/org/apache/hadoop/hbase/client/HConnectionManager.java
SoftSortedMap was renamed SoftValueSortedMap.
{code}
> Enable BLOCKCACHE by default [WAS -> Reevaluate HBASE-288 block caching
> work....?]
> ----------------------------------------------------------------------------------
>
> Key: HBASE-953
> URL: https://issues.apache.org/jira/browse/HBASE-953
> Project: Hadoop HBase
> Issue Type: Task
> Reporter: stack
> Priority: Critical
> Fix For: 0.19.0
>
> Attachments: blockcache.patch
>
>
> Go back and take another look at the Tom White work. We've gotten boost in
> writing and scanning because of J-D work. HBASE-288 looks like it boosts
> sequential reads and perhaps random read a little. Take another look.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.