[ 
https://issues.apache.org/jira/browse/HBASE-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703505#action_12703505
 ] 

stack commented on HBASE-1249:
------------------------------

Looking at the GetQuery-v4:

+ TimeStamp looks like CellBounds in 880 proposal 5 v2 only its missing 
versions.  How are versions done?
+ Is the Family object needed?  The old array of arrays where columns were 
compound of family and qualifier would seem to be more compact?
+ How do I read GetXServer?  Is that the client-side GetX that has been 
deserialized Server-side?   The GetXServer.compareTo will take into 
consideration the TimeRange?  I think I like it.  Why do I need result 2 and 3 
out of the compareTo?  Whats wrong with the compareTo working like any other 
comparator returning < 0, 0, or > 0?  If 0, we add to the result.  If > 0, 
we've gone past whatever our context, storefile or store, and then in the loop 
we just move on to the next storefile or store.  Shouldn't be compareTo if 
returning different kind of results.
+ What about deletes?  They are orthogonal to this compareTo test?  They are a 
running list that we bring along with our results as we do currently?  Looks 
like you have this thing called NewDeletes that GetX knows about?
+ How does your DeleteSet work?  How will it delete with different types (e.g. 
what do you add to this Set?  Deletes?  If so, how you going to have the Put 
something is supposed to Delete match in the comparator?  Currently I have a 
special comparator that ignores types... that won't be good enough if need to 
consider family, column and plain deletes).
+ We're changing how filters work?

> Rearchitecting of server, client, API, key format, etc for 0.20
> ---------------------------------------------------------------
>
>                 Key: HBASE-1249
>                 URL: https://issues.apache.org/jira/browse/HBASE-1249
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Jonathan Gray
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1249-Example-v1.pdf, HBASE-1249-Example-v2.pdf, 
> HBASE-1249-GetQuery-v1.pdf, HBASE-1249-GetQuery-v2.pdf, 
> HBASE-1249-GetQuery-v3.pdf, HBASE-1249-GetQuery-v4.pdf, 
> HBASE-1249-StoreFile-v1.pdf, HBASE-1249-StoreFile-v4.pdf
>
>
> To discuss all the new and potential issues coming out of the change in key 
> format (HBASE-1234): zero-copy reads, client binary protocol, update of API 
> (HBASE-880), server optimizations, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to