[ 
https://issues.apache.org/jira/browse/HBASE-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707234#action_12707234
 ] 

Erik Holstad commented on HBASE-1249:
-------------------------------------

@jgray
Yeah, it's is a little weird, cause when I pasted it, it looked really good in 
the window, but now it looks really bad.

@Stack
Not really sure what is considered to be very different, I do think that the 
difference is quite big
The only methods that stays pretty much the same is reset() and filterColumn 
which changes name to filterQualifier since we are trying to get rid of the 
column notion.
The filterRowKey could be used as filterRow, but since we only take a byte[] as 
input we can't use the KeyValue from the scanners but have to do a copy for 
every check, which seems like
an unnecessary  thing to do, specially since the whole plan on the server side 
is to avoid copying.
I'm not dying to rewrite the filters, but have started, cause I don't really 
seem how we could use the old ones in a good way, but if you see a way for us 
to do that, I'm happy to not do the work.
. 

> Rearchitecting of server, client, API, key format, etc for 0.20
> ---------------------------------------------------------------
>
>                 Key: HBASE-1249
>                 URL: https://issues.apache.org/jira/browse/HBASE-1249
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Jonathan Gray
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1249-Example-v1.pdf, HBASE-1249-Example-v2.pdf, 
> HBASE-1249-GetQuery-v1.pdf, HBASE-1249-GetQuery-v2.pdf, 
> HBASE-1249-GetQuery-v3.pdf, HBASE-1249-GetQuery-v4.pdf, 
> HBASE-1249-StoreFile-v1.pdf, HBASE-1249-StoreFile-v4.pdf
>
>
> To discuss all the new and potential issues coming out of the change in key 
> format (HBASE-1234): zero-copy reads, client binary protocol, update of API 
> (HBASE-880), server optimizations, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to